Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Dockerfile of clusterctl #305

Merged
merged 1 commit into from
Apr 20, 2019
Merged

add Dockerfile of clusterctl #305

merged 1 commit into from
Apr 20, 2019

Conversation

hchenxa
Copy link
Contributor

@hchenxa hchenxa commented Apr 17, 2019 •
edited
Loading

What this PR does / why we need it:

Create the Dockerfile so that we can build the clusterctl docker image for:

  1. Use k8s job/cronjob to create the k8s cluster
  2. Integrate with knative to use tekon pipeline for k8s cluster deploy.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #304

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 17, 2019
@hchenxa hchenxa changed the title add Dockerfile for clusterctl add Dockerfile of clusterctl Apr 17, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @hchenxa. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2019
gyliu513
gyliu513 reviewed Apr 17, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@gyliu513
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 17, 2019
@gyliu513
Copy link
Contributor

/cc @jichenjc @chrigl

@k8s-ci-robot k8s-ci-robot requested review from chrigl and jichenjc April 17, 2019 07:03
jichenjc
jichenjc requested changes Apr 18, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2019
@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2019
gyliu513
gyliu513 reviewed Apr 19, 2019
View reviewed changes
Makefile Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2019
@gyliu513
Copy link
Contributor

/approve

/cc @jichenjc

@k8s-ci-robot k8s-ci-robot requested a review from jichenjc April 20, 2019 01:17
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, hchenxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2019
@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 800c59e into kubernetes-sigs:master Apr 20, 2019
@gyliu513 gyliu513 mentioned this pull request Apr 23, 2019
Closed
@hchenxa hchenxa mentioned this pull request Apr 28, 2019
Closed
6 tasks
@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
pierreprinetti referenced this pull request in shiftstack/cluster-api-provider-openstack Apr 22, 2024
@hchenxa @pierreprinetti
add Dockerfile for clusterctl (openshift#305)
3109408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyliu513 gyliu513 gyliu513 left review comments

@scruplelesswizard scruplelesswizard Awaiting requested review from scruplelesswizard

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

@chrigl chrigl Awaiting requested review from chrigl

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@gyliu513 gyliu513

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hchenxa @k8s-ci-robot @gyliu513 @jichenjc